| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Fix warnings and typo in dshash |
| Date: | 2018-03-02 00:29:57 |
| Message-ID: | 20180302002957.njovdbubb6wofnzz@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-02-12 09:23:43 +1300, Thomas Munro wrote:
> On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro
> > <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> >> I think it should be (size_t) 1, not UINT64CONST(1). See attached.
> >
> > Okay, that makes sense. Do you think we should also change type
> > casting in BUCKETS_PER_PARTITION so that we are consistent?
>
> +1
>
> Here's a patch to fix that. I was reminded to come back and tidy this
> up when I spotted a silly mistake in a nearby comment, also fixed in
> this patch.
Pushed.
Thanks,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-02 00:30:00 | Re: Removing shm_mq.c's volatile qualifiers |
| Previous Message | Andres Freund | 2018-03-02 00:19:20 | Re: Rewrite of pg_dump TAP tests |