| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-01-24 15:45:48 |
| Message-ID: | 20180124154548.gmpyvkzlsijren7u@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
A quick suggestion from a passer-by -- would you put the new code in
src/backend/storage/ipc/backend_signal.c instead? Sounds like a better
place than utils/misc/; and "signal" is more general in nature than just
"cancel". A bunch of stuff from utils/adt/misc.c (???) can migrate to
the new file -- everything from line 201 to 362 at least, that is:
pg_signal_backend
pg_cancel_backend
pg_terminate_backend
pg_reload_conf
pg_rotate_logfile
Maybe have two patches, 0001 creates the files moving the contents over,
then 0002 adds your new stuff on top.
/me wonders if there's anything that would suggest to make this
extensive to processes other than backends ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-01-24 15:49:38 | Re: documentation is now XML |
| Previous Message | David Fetter | 2018-01-24 15:15:28 | Re: documentation is now XML |