Re: [HACKERS] [PATCH] Lockable views

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] [PATCH] Lockable views
Date: 2017-12-31 10:57:13
Message-ID: 20171231195713.660dbeaa.nagata@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi,

The updated patch is attached.

On Fri, 29 Dec 2017 23:39:39 +0900 (JST)
Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:


> The patch produces a warning.
>
> /home/t-ishii/lock_view-v3.patch:542: trailing whitespace.
> -- Verify that we can lock a auto-updatable views
> warning: 1 line adds whitespace errors.

Fixed.

>
> Your addition to the doc:
> + Automatically updatable views (see <xref linkend="sql-createview">)
> + that do not have <literal>INSTEAD OF</> triggers or <literal>INSTEAD</>
> + rules are also lockable. When a view is locked, its base relations are
> + also locked recursively with the same lock mode.
>
> does not mention about the point:
>
> >> >> > 1) Leave as it is (ignore tables appearing in a subquery)

I added this point to the documentation.

Regards,

>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
lock_view-v4.patch text/x-diff 22.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2017-12-31 10:58:22 Re: Logical decoding fast-forward and slot advance
Previous Message Michael Paquier 2017-12-31 10:51:21 Re: Why standby restores some WALs many times from archive?