Re: [HACKERS] Bug in to_timestamp().

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: amul sul <sulamul(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, Bruce Momjian <bruce(at)momjian(dot)us>, amul sul <sul_amul(at)yahoo(dot)co(dot)in>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Bug in to_timestamp().
Date: 2017-11-22 15:23:36
Message-ID: 20171122152334.GA571@zakirov.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I've attached new version of the patch. It is a little bit simpler now than the previous one.
The patch doesn't handle backslashes now, since there was a commit which fixes quoted-substring handling recently.
Anyway I'm not sure that this handling was necessary.

I've checked queries from this thread. It seems that they give right timestamps and work like in Oracle (except different messages).

The patch contains documentation and regression test fixes.

On Sun, Nov 19, 2017 at 12:26:39PM -0500, Tom Lane wrote:
> I don't much like the error message that you've got:
> +SELECT to_timestamp('97/Feb/16', 'FXYY:Mon:DD');
> +ERROR: unexpected character "/", expected ":"
> +DETAIL: The given value did not match any of the allowed values for this field.
> The DETAIL message seems to have been copied-and-pasted into a context
> where it's not terribly accurate. I'd consider replacing it with
> something along the lines of "HINT: In FX mode, punctuation in the input
> string must exactly match the format string." This way the report will
> contain a pretty clear statement of the new rule that was broken. (BTW,
> it's a hint not a detail because it might be guessing wrong as to what
> the real problem is.)
> regards, tom lane

Messages have the following format now:

SELECT to_timestamp('97/Feb/16', 'FXYY:Mon:DD');
ERROR: unexpected character "/", expected ":"
HINT: In FX mode, punctuation in the input string must exactly match the format string.

Arthur Zakirov
Postgres Professional:
Russian Postgres Company

Attachment Content-Type Size
0001-to-timestamp-format-checking-v8.patch text/x-diff 15.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2017-11-22 15:37:14 Re: [PATCH] using arc4random for strong randomness matters.
Previous Message Tom Lane 2017-11-22 15:19:23 Re: Query became very slow after 9.6 -> 10 upgrade