| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Lukas Fittl <lukas(at)fittl(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Re: BUG #14821: idle_in_transaction_session_timeout sometimes gets ignored when statement timeout is pending |
| Date: | 2017-10-11 21:11:20 |
| Message-ID: | 20171011211120.2qpv4gzirbh7rbrg@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Hi,
On 2017-09-20 20:27:05 -0700, Lukas Fittl wrote:
> As per the bug report at
> https://www.postgresql.org/message-id/20170921010956.17345.61461%40wrigleys.postgresql.org
> it seems that the query cancellation holdoff logic in ProcessInterrupts is
> a bit overly aggressive in keeping other interrupts from running.
>
> In particular I've seen an issue in the wild where
> idle_in_transaction_session_timeout did not get triggered because
> the HOLD_CANCEL_INTERRUPTS() in SocketBackend wraps around a pq_getbyte()
> call, and so ProcessInterrupts doesn't do anything when it gets called
> because the query cancel holdoff counter is positive.
>
> Andres suggested the following re-ordering of the logic on -bugs:
I've pushed this. Thanks for the report & fix!
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Tiikkaja | 2017-10-11 21:16:11 | Re: BUG #14830: Missed NOTIFications, PostgreSQL 9.1.24 |
| Previous Message | Tom Lane | 2017-10-11 19:51:32 | Re: Combination of ordered-set aggregate function terminates JDBC connection on PostgreSQL 9.6.5 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-10-11 21:28:16 | Re: Windows warnings from VS 2017 |
| Previous Message | Tom Lane | 2017-10-11 20:58:21 | Re: Omission in GRANT documentation |