Re: [PATCH] Add citext_pattern_ops to citext contrib module

From: Alexey Chernyshov <a(dot)chernyshov(at)postgrespro(dot)ru>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add citext_pattern_ops to citext contrib module
Date: 2017-09-14 09:22:37
Message-ID: 20170914122237.5b1fc950@PostgresPro-A-Chernyshov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, 12 Sep 2017 12:59:20 -0400
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Quick comment on this patch: recently, we've decided that having
> patches replace the whole base script for an extension is too much of
> a maintenance problem, especially when there are several patches in
> the pipeline for the same contrib module. The new style is to
> provide only a version update script (which you'd have to write
> anyway), and then rely on CREATE EXTENSION to apply the old base
> script plus the update(s). You can see some examples in the patch I
> just posted at
> Also, since that patch is probably going to get committed pretty
> soon, you could reformulate your patch as an add-on to its
> citext--1.4--1.5.sql script. We don't really need to have a separate
> version of the extension for states that are intermediate between two
> PG major releases. Only if your patch doesn't get in by v11 freeze
> would you need to make it a separate citext--1.5--1.6.sql script.
> regards, tom lane

Accented characters and different length strings tests added.
Since patch
is committed, I changed the patch as you said. Thanks for your notes.
Do we need expected/citext.out? It seems that only
expected/citext_1.out has correct output.

Alexey Chernyshov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
citext_pattern_ops-v2.patch text/x-patch 21.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-09-14 09:36:39 Re: Setting pd_lower in GIN metapage
Previous Message Alvaro Hernandez 2017-09-14 09:21:52 Re: SCRAM in the PG 10 release notes