Re: show "aggressive" or not in autovacuum logs

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: sawada(dot)mshk(at)gmail(dot)com
Cc: robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: show "aggressive" or not in autovacuum logs
Date: 2017-09-05 06:41:17
Message-ID: 20170905.154117.22652537.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Thank you for the opinions.

At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote in <CAD21AoD76_QkYBwu8=NuMv0sp3Dec9X+DufB6-XbQyuuUUHh8g(at)mail(dot)gmail(dot)com>
> On Tue, Aug 29, 2017 at 10:16 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI
> > <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> >> Currently the message shows the '%d skipped-frozen' message but
> >> it is insufficient to verify the true effect. This is a patch to
> >> show mode as 'aggressive' or 'normal' in the closing message of
> >> vacuum. %d frozen-skipped when 'aggressive mode' shows the true
> >> effect of ALL_FROZEN.
> >>
> >> I will add this patch to CF2017-09.
> >
> > I would be a bit inclined to somehow show aggressive if it's
> > aggressive and not insert anything at all otherwise. That'd probably
> > require two separate translatable strings in each case, but maybe
> > that's OK.
> >
> > What do other people think?
>
> FWIW I prefer the Robert's idea; not insert anything if normal vacuum.

Though the form is intending to simplify parsing of the message,
keeping the previous format if nothing special is convincing.

How about the followings?

"automatic [agressive ]vacuum of table \"%s..."
"[aggressive ]vacuuming \"%s..."

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Show-aggressive-or-not-in-vacuum-messages.patch text/x-patch 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-09-05 06:43:21 Re: Partition-wise join for join between (declaratively) partitioned tables
Previous Message Amit Langote 2017-09-05 06:36:30 Re: Partition-wise join for join between (declaratively) partitioned tables