Confusing error message in pgbench

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Confusing error message in pgbench
Date: 2017-08-02 02:03:28
Message-ID: 20170802.110328.1963639094551443169.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

I found an error message in pgbench is quite confusing.

pgbench -S -M extended -c 1 -T 30 test
query mode (-M) should be specified before any transaction scripts (-f or -b)

Since there's no -f or -b option is specified, users will be
confused. Actually the error occurs because pgbench implicitly
introduces a built in script for -S. To eliminate the confusion, I
think the error message should be fixed like this:

query mode (-M) should be specified before transaction type (-S or -N) or any transaction scripts (-f or -b)

Patch attached.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
pgbench.diff text/x-patch 611 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-08-02 02:10:24 Re: Proposal for CSN based snapshots
Previous Message Noah Misch 2017-08-02 02:01:15 Re: VACUUM and ANALYZE disagreeing on what reltuples means