| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: snapbuild woes |
| Date: | 2017-05-01 01:35:29 |
| Message-ID: | 20170501013529.sejtgo2acxbvq26q@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-04-30 17:59:21 -0700, Andres Freund wrote:
> ISTM, we need a xip_status array in SnapBuild->running. Then, whenever
> a xl_running_xacts is encountered while builder->running.xcnt > 0, loop
> for i in 0 .. xcnt_space, and end SnapBuildEndTxn() if xip_status[i] but
> the xid is not xl_running_xacts? Does that make sense?
A hasty implementation, untested besides check-world, of that approach
is attached. I'm going out for dinner now, will subject it to mean
things afterwards.
Needs more testing, comment and commit message policing. But I think
the idea is sound?
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-initial-logical-decoding-snapshat-race-condition.patch | text/x-patch | 10.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-05-01 01:51:26 | Newbie project: Detect attempts to run pg_dump etc on psql, \copy on server |
| Previous Message | Amit Langote | 2017-05-01 01:24:44 | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |