From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | an outdated comment for hash_seq_init. |
Date: | 2017-04-24 07:55:41 |
Message-ID: | 20170424.165541.230634914.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello.
While I looked into dynahash.c, I found that the following
sentense became outdated by 5dfc198. The commit removed the only
usage of hash_freeze().
> * NOTE: it is possible to use hash_seq_init/hash_seq_search without any
> * worry about hash_seq_term cleanup, if the hashtable is first locked against
> * further insertions by calling hash_freeze. This is used by nodeAgg.c,
> * wherein it is inconvenient to track whether a scan is still open, and
> * there's no possibility of further insertions after readout has begun.
The attached patch removes the sentence begins with "This is used
by..".
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
edit_comment_for_hash_seq_init.patch | text/x-patch | 834 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Konstantin Knizhnik | 2017-04-24 08:46:02 | Cached plans and statement generalization |
Previous Message | Ideriha, Takeshi | 2017-04-24 07:50:22 | Re: visual studio 2017 build support |