Re: [PATCH] Remove unused argument in btree_xlog_split

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Subject: Re: [PATCH] Remove unused argument in btree_xlog_split
Date: 2017-04-06 12:21:17
Message-ID: 20170406122116.GA11081@e733.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Robert,

> Hmm. I don't see anything wrong with that, particularly, but it seems
> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
> XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
> XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
> a little further and do all of that together.

Thank you for sharing your thoughts on this patch. Here is a new
version.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
btree_xlog_split_refactoring_v2.patch text/x-diff 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2017-04-06 12:24:41 subscription worker doesn't start immediately on eabled
Previous Message David Rowley 2017-04-06 12:13:58 Re: BRIN cost estimate