Skip site navigation (1) Skip section navigation (2)

Re: Patch: Write Amplification Reduction Method (WARM)

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>,Robert Haas <robertmhaas(at)gmail(dot)com>,Bruce Momjian <bruce(at)momjian(dot)us>,Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>,Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>,Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>,pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
Date: 2017-03-29 17:08:13
Message-ID: 20170329170813.te3jgps7wdgvzq4z@alvherre.pgsql (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
Pavan Deolasee wrote:
> On Wed, Mar 29, 2017 at 3:42 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
> wrote:
> 
> > I pushed 0002 after some makeup, since it's just cosmetic and not
> > controversial.
> 
> Thanks. I think your patch of tracking interesting attributes seems ok too
> after the performance issue was addressed. Even though we can still improve
> that further, at least Mithun confirmed that there is no significant
> regression anymore and in fact for one artificial case, patch does better
> than even master.

Great, thanks.  I pushed it, too.  One optimization we could try is
using slot deform instead of repeated heap_getattr().  Patch is
attached.  I haven't benchmarked it.

On top of that, but perhaps getting in the realm of excessive
complication, we could see if the bitmapset is a singleton, and if it is
then do heap_getattr without creating the slot.  That'd require to have
a second copy of heap_tuple_attr_equals() that takes a HeapTuple instead
of a TupleTableSlot.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment: interesting-speedup.patch
Description: text/plain (2.2 KB)

In response to

pgsql-hackers by date

Next:From: Arthur ZakirovDate: 2017-03-29 17:14:27
Subject: Re: [PATCH] Generic type subscripting
Previous:From: Andrew DunstanDate: 2017-03-29 16:28:08
Subject: Re: [PATCH] few fts functions for jsonb

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group