Re: Re: Declarative partitioning optimization for large amount of partitions

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: Declarative partitioning optimization for large amount of partitions
Date: 2017-03-24 16:12:04
Message-ID: 20170324161204.GD16830@e733.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi Teodor,

Thanks a lot for a review!

> > step1 In pgstat_report_stat() you remove one by one entries from hash and
> > remove them all. Isn't it better to hash_destroy/hash_create or even let hash
> > lives in separate memory context and just resets it?

Agree, fixed.

> > step1 Again, pgstat_report_stat(), all-zero entries aren't deleted from hash
> > although they will be free from point of view of pgStatTabList.

Good point! Fixed.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
partitioning_bottleneck_fix_v4_step1.patch text/x-diff 4.6 KB
partitioning_bottleneck_fix_v4_step2.patch text/x-diff 3.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-03-24 16:14:26 Re: [COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()
Previous Message Amit Khandekar 2017-03-24 16:02:57 Re: Parallel Append implementation