Re: Re: Declarative partitioning optimization for large amount of partitions

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: Declarative partitioning optimization for large amount of partitions
Date: 2017-03-24 12:17:44
Message-ID: 20170324121744.GA16470@e733.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi Anastasia,

Thanks a lot for a review!

As was mentioned above there is also a bottleneck in find_all_inheritors
procedure. Turned out the problem there is similar and it could be easily
fixed as well. Corresponding patch is attached to this message. To keep
things in order I'm attaching the previous patch as well.

On Wed, Mar 22, 2017 at 11:53:45AM +0000, Anastasia Lubennikova wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: not tested
>
> The patch looks good to me.
> It applies clearly, passes all the tests and eliminates the bottleneck described in the first message.
> And as I can see from the thread, there were no objections from others,
> except a few minor comments about code style, which are fixed in the last version of the patch.
> So I mark it "Ready for committer".
>
> The new status of this patch is: Ready for Committer
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
partitioning_bottleneck_fix_v3_step1.patch text/x-diff 4.5 KB
partitioning_bottleneck_fix_v3_step2.patch text/x-diff 3.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-03-24 12:18:04 Re: increasing the default WAL segment size
Previous Message Petr Jelinek 2017-03-24 11:48:35 Re: Logical replication existing data copy