Re: One-shot expanded output in psql using \gx

From: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>
To: Daniel Verite <daniel(at)manitou-mail(dot)org>
Cc: David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: One-shot expanded output in psql using \gx
Date: 2017-03-06 12:42:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Re: Daniel Verite 2017-03-03 <4d84079e-325b-48c5-83e6-bb54bb567bb1(at)manitou-mail(dot)org>
> - tab-completion: works but the list in tab-complete.c:backslash_commands[]
> is sorted alphabetically so "\\gx" should come after "\\gset"

Good catch, it was still in that place from when it was named \G.

In the \? output I left it directly after \g because the help text
starts with "as \g ..." and it is IMHO more closely related to \g than
\gexec and \gset which differ more in functionality.

> unsigned short int expanded; /* expanded/vertical output (if supported
> by
> * output format); 0=no, 1=yes, 2=auto */
> Although there is still code that puts true/false in this variable
> (probably because it was a bool before?), I assume that for new
> code, assigning 0/1/2 should be preferred.

Right. I had seen both being used and went with "true", but "1" is
better style.

Both fixed, thanks for the review! Version 3 attached.

Senior Berater, Tel.: +49 2166 9901 187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
pgp fingerprint: 5C48 FE61 57F4 9179 5970 87C6 4C5A 6BAB 12D2 A7AE

Attachment Content-Type Size
expanded-mode-gx-3.patch text/x-diff 6.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Giuseppe Broccolo 2017-03-06 12:49:24 dump a comment of a TSDictionary
Previous Message Tom Lane 2017-03-06 12:38:44 Re: PATCH: Configurable file mode mask