| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Cannot shutdown subscriber after DROP SUBSCRIPTION |
| Date: | 2017-02-01 08:36:23 |
| Message-ID: | 20170201.173623.66249355.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, while looking another bug, I found that standby cannot
shutdown after DROP SUBSCRIPTION.
standby=# CREATE SUBSCRPTION sub1 ...
standby=# ....
standby=# DROP SUBSCRIPTION sub1;
Ctrl-C to the standby fails to work. ApplyLauncherMain is waiting
LogicalRepLauncherLock forever.
The culprit is DropSbuscription. It acquires
LogicalRepLauncherLock but never releases.
The attached patch fixes it. Most part of the fucntion is now
enclosed by PG_TRY-CATCH since some functions can throw
exceptions.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_block_by_drop_subscription_v1.patch | text/x-patch | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-02-01 08:37:48 | Re: IF (NOT) EXISTS in psql-completion |
| Previous Message | Nikhil Sontakke | 2017-02-01 08:29:25 | Re: Speedup twophase transactions |