Re: IF (NOT) EXISTS in psql-completion

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: pavel(dot)stehule(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: IF (NOT) EXISTS in psql-completion
Date: 2016-12-26 08:40:58
Message-ID: 20161226.174058.113723696.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> Thanks for reviewing but I ran out of time for this CF..
>
> I'm going to move this to the next CF.

I splitted the patch into small pieces. f3fd531 conflicted to
this so rebased onto the current master HEAD.

0001 is psql_completion refactoring.
0002-0003 are patches prividing new infrastructures.
0004 is README for the infrastructures.
0005 is letter-case correction of SET/RESET/SHOW using 0002.
0006-0008 are improvements of recursive syntaxes using 0001 and 0004.
0009-0016 are simplifying (maybe) completion code per syntax.

The last one (0017) is the IF(NOT)EXIST modifications. It
suggests if(not)exists for syntaxes already gets object
suggestion. So some kind of objects like operator, cast and so
don't get an if.. suggestion. Likewise, I intentionally didn't
modified siggestions for "TEXT SEARCH *".

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Refactoring-tab-complete-to-make-psql_completion-cod.patch text/x-patch 132.6 KB
0002-Make-keywords-case-follow-to-input.patch text/x-patch 41.6 KB
0003-Introduce-word-shift-and-removal-feature-to-psql-com.patch text/x-patch 15.1 KB
0004-Add-README-for-tab-completion.patch text/x-patch 6.7 KB
0005-Make-SET-RESET-SHOW-varialble-follow-input-letter-ca.patch text/x-patch 2.8 KB
0006-Allow-complete-schema-elements-in-more-natural-way.patch text/x-patch 13.7 KB
0007-Allow-CREATE-RULE-to-use-command-completion-recursiv.patch text/x-patch 5.1 KB
0008-Allow-completing-the-body-of-EXPLAIN.patch text/x-patch 1.2 KB
0009-Simpilfy-ALTER-TABLE-ALTER-COLUMN-completion.patch text/x-patch 2.6 KB
0010-Simplify-completion-for-CLUSTER-VERBOSE.patch text/x-patch 1.6 KB
0011-Simplify-completion-for-COPY.patch text/x-patch 2.6 KB
0012-Simplify-completion-for-CREATE-INDEX.patch text/x-patch 4.4 KB
0013-Simplify-completion-for-CREATE-SEQUENCE.patch text/x-patch 1.3 KB
0014-Simplify-completion-for-DROP-INDEX.patch text/x-patch 1.2 KB
0015-Add-CURRENT_USER-to-some-completions-of-role.patch text/x-patch 4.8 KB
0016-Simplify-completion-for-ALTER-DEFAULT-PRIVILEGES.patch text/x-patch 3.8 KB
0017-Add-suggestions-of-IF-NOT-EXISTS.patch text/x-patch 17.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2016-12-26 09:44:30 Re: Parallel bitmap heap scan
Previous Message Kyotaro HORIGUCHI 2016-12-26 08:31:47 Re: Protect syscache from bloating with negative cache entries