Re: Remove superuser() checks from pgstattuple

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove superuser() checks from pgstattuple
Date: 2016-09-28 15:38:16
Message-ID: 20160928153816.GV5148@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Michael,

* Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> On Tue, Sep 27, 2016 at 4:43 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > * Peter Eisentraut (peter(dot)eisentraut(at)2ndquadrant(dot)com) wrote:
> >> This is now being obsoleted by the later idea of allowing base installs
> >> from a chain of upgrade scripts. But if your upgrade scripts contain
> >> ALTER TABLE commands, you will probably still want to write base install
> >> scripts that do a fresh CREATE TABLE instead.
> >
> > I've updated the patch to remove the new base version script and to rely
> > on the changes made by Tom to install the 1.4 version and then upgrade
> > to 1.5.
> >
> > Based on my testing, it appears to all work correctly.
>
> Same conclusion from here.

Fantastic, thanks for the testing!

> > Updated (much smaller) patch attached.
>
> I had a look at it, and it is doing the work it claims to do. So I am
> marking it as "Ready for Committer".

Great. I'm going to go over the whole patch closely again and will push
it soon.

Thanks again!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-09-28 15:39:21 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Robert Haas 2016-09-28 15:27:36 Re: assert violation in logical messages serialization