Re: IF (NOT) EXISTS in psql-completion

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: pavel(dot)stehule(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: IF (NOT) EXISTS in psql-completion
Date: 2016-09-06 13:00:26
Message-ID: 20160906.220026.127011211.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hello, this is the new version of this patch. Rebased on the
current master.

At Tue, 06 Sep 2016 13:06:51 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20160906(dot)130651(dot)171572544(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> Thank you. I'll rebase the following patch and repost as soon as
> possible.
>
> https://www.postgresql.org/message-id/20160407.211917.147996130.horiguchi.kyotaro@lab.ntt.co.jp

This patch consists of the following files. Since these files are
splitted in strange criteria and order for historical reasons,
I'll reorganize this and post them later.

- 0001-Suggest-IF-NOT-EXISTS-for-tab-completion-of-psql.patch

Add suggestion of IF (NOT) EXISTS on master. This should be the
last patch in this patchset.

- 0002-Make-added-keywords-for-completion-queries-follow-to.patch

Current suggestion mechanism doesn't distinguish object names
and keywords, which should be differently handled in
determining letter cases. This patch fixes that.

- 0003-Make-COMPLETE_WITH_ATTR-to-accept-additional-keyword.patch

This patch apply the 0002 fix to COMPLET_WITH_ATTR.

- 0004-Refactoring-tab-complete-to-make-psql_completion-cod.patch

By Tom's suggestion, in order to modify previous_words in more
sane way, transforming the else-if sequence in psql_completion
into a simple if sequence.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Suggest-IF-NOT-EXISTS-for-tab-completion-of-psql.patch text/x-patch 45.4 KB
0002-Make-added-keywords-for-completion-queries-follow-to.patch text/x-patch 24.0 KB
0003-Make-COMPLETE_WITH_ATTR-to-accept-additional-keyword.patch text/x-patch 66.0 KB
0004-Refactoring-tab-complete-to-make-psql_completion-cod.patch text/x-patch 147.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2016-09-06 13:01:44 Re: Proposal for changes to recovery.conf API
Previous Message Etsuro Fujita 2016-09-06 12:45:34 Push down more UPDATEs/DELETEs in postgres_fdw