Re: fd.c: flush data problems on osx

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fd.c: flush data problems on osx
Date: 2016-04-02 01:32:00
Message-ID: 20160402013200.GA1555982@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 21, 2016 at 03:09:56PM +0300, Stas Kelvich wrote:
> On 21 Mar 2016, at 14:53, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Hm. I think we should rather just skip calling pg_flush_data in the
> > directory case, that very likely isn't beneficial on any OS.
>
> Seems reasonable, changed.
>
> > I think we still need to fix the mmap() implementation to support the
> > offset = 0, nbytes = 0 case (via fseek(SEEK_END).
>
> It is already in this diff. I’ve added this few messages ago.

[This is a generic notification.]

The above-described topic is currently a PostgreSQL 9.6 open item. Andres,
since you committed the patch believed to have created it, you own this open
item. If that responsibility lies elsewhere, please let us know whose
responsibility it is to fix this. Since new open items may be discovered at
any time and I want to plan to have them all fixed well in advance of the ship
date, I will appreciate your efforts toward speedy resolution. Please
present, within 72 hours, a plan to fix the defect within seven days of this
message. Thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2016-04-02 01:56:12 pgsql: Refer to a TOKEN_USER payload as a "token user, " not as a "user
Previous Message Stephen Frost 2016-04-02 01:23:54 Re: pg_dump dump catalog ACLs