|From:||Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>|
|Cc:||tgl(at)sss(dot)pgh(dot)pa(dot)us, kgrittn(at)gmail(dot)com, kgrittn(at)ymail(dot)com, simon(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: PATCH: index-only scans with partial indexes|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Thank you for the comment. The new version is attached.
Some issues has not been addressed but the rest will be addresses
in the next version.
At Thu, 31 Mar 2016 08:42:50 +0200, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote in <90d885f2-e5ce-6668-226f-c817154e4f73(at)2ndquadrant(dot)com>
> On 03/31/2016 01:36 AM, Tom Lane wrote:
> > Kevin Grittner <kgrittn(at)gmail(dot)com> writes:
> >> I'm taking my name off as committer and marking it "Ready for
> >> Committer". If someone else wants to comment on the issues where
> >> Tom and Kyotaro-san still seem unsatisfied to the point where I
> >> can get my head around it, I could maybe take it back on as
> >> committer -- if anyone feels that could be a net win.
> > I'll pick it up. In a quick scan I see some things I don't like, but
> > nothing insoluble:
> > * Having plancat.c initialize the per-IndexOptInfo restriction lists
> > * seems
> > fairly bizarre. I realize that Tomas or Kyotaro probably did that in
> > response to my complaint about having check_partial_indexes have
> > side-effects on non-partial indexes, but this isn't an improvement.
I felt the same thing for it. It is for discussion. It is the
earliest point where we can initialize baserestrictinfo of each
IndexOptInfo. And the original location is just after and is the
latest point. Reverted.
> > For one thing, it means we will produce an incorrect plan if
> > more restriction clauses are added to the rel after plancat.c
> > runs, as the comment for check_partial_indexes contemplates.
Mmm. Thank you. I overlooked that. The following code seems
saying related thing.
> if (index->predOK)
> continue; /* don't repeat work if already proven OK */
So, index restrinctioninfo should be calculated even if
index->predOK is already true. But refactroring suggested by the
following comment will fix this.
> > (I *think* that comment may be obsolete, but I'm not sure.)
> > I think a better answer to that complaint is to rename
> > check_partial_indexes to something else, and more importantly
> > adjust its header comment to reflect its expanded
> > responsibilities --- as the patch I was commenting on at the
> > time failed to do.
Ok, I removed the index baserestrictinfo (a bit long to repeat..)
creation out of check_partial_indexes and named
rebuild_index_restrictinfo. (calling for better names..)
This loosens the restriction on the timing to trim an index
restrictinfo. It is now moved to create_index_paths.
> > * It took me some time to convince myself that the patch doesn't break
> > generation of plans for EvalPlanQual. I eventually found where it
> > skips removal of restrictions for target relations, but that's
> > drastically undercommented.
It is originally in create_indexscan_plan and had no
documentation about EPQ. But I also want such documentation there
so I added it on in rebuild_index_restrictinfo.
> > * Likewise, there's inadequate documentation of why it doesn't break
> > bitmap scans, which also have to be able to recheck correctly.
This trims clauses that implied by index predicate, which
donesn't need recheck even if it is a bitmap scan, I believe. Is
it wrong? The original comment on check_index_only said that,
> * XXX this is overly conservative for partial indexes, since we will
> * consider attributes involved in the index predicate as required even
> * though the predicate won't need to be checked at runtime. (The same is
> * true for attributes used only in index quals, if we are certain that
> * the index is not lossy.) However, it would be quite expensive to
> * determine that accurately at this point, so for now we take the easy
> * way out.
This seems to me that such clauses are safely ignored. But not
for attributes used only in index quals, because of possible
lossy charcter of the index. It seems quite reasonable. This
optimization won't be hold if this comment is wrong.
> > * I'm not sure that we have any regression test cases covering the
> > above two points, but we should.
I agree. Will try to add in the next version, maybe posted tomorrow.
> > * The comments leave a lot to be desired in general, eg there are
> > repeated failures to update comments only a few lines away from a
> > change.
I'll recheck that and fix in the next version.
> I may look into fixing those issues early next week, but that's fairly
> close to the freeze. Also, I'll have to look into parts that I'm not
> very familiar with (like the EvalPlanQual), so feel free to address
> those issues ;-)
NTT Open Source Software Center
|Next Message||Dmitry Dolgov||2016-03-31 13:00:58||Re: [PATH] Jsonb, insert a new value into an array at arbitrary position|
|Previous Message||Andres Freund||2016-03-31 12:24:55||Re: Speed up Clog Access by increasing CLOG buffers|