Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Marco Atzeri <marco(dot)atzeri(at)gmail(dot)com>
Subject: Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Date: 2016-01-08 15:39:02
Message-ID: 20160108153902.GA589413@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > Blind attempt at a Cygwin fix
> >
> > According to
> > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=brolga&dt=2016-01-08%2014%3A51%3A27
> >
> > brolga now tries to compile win32security.c, which it evidently was not
> > doing before, but the compile blows up; looks like it is missing #include
> > calls (which must exist in other places where this code lives ...)
>
> Obviously this wasn't the best idea ever. Andrew suggests on IM to
> revert this on Cygwin to just do the "isatty" check as originally.

Here's a proposed patch. Thoughts?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
Revert-Blind-attempt-at-a-Cygwin-fix.patch text/x-diff 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-01-08 16:17:35 Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Previous Message Tom Lane 2016-01-08 15:31:10 Re: dblink: add polymorphic functions.

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-01-08 16:17:35 Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix
Previous Message Alvaro Herrera 2016-01-08 15:13:31 Re: [COMMITTERS] pgsql: Blind attempt at a Cygwin fix