Re: Replication identifiers, take 4

From: Andres Freund <andres(at)anarazel(dot)de>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Replication identifiers, take 4
Date: 2015-04-24 12:32:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2015-04-20 11:26:29 +0300, Heikki Linnakangas wrote:
> On 04/17/2015 11:54 AM, Andres Freund wrote:
> >I've attached a rebased patch, that adds decision about origin logging
> >to the relevant XLogInsert() callsites for "external" 2 byte identifiers
> >and removes the pad-reusing version in the interest of moving forward.
> Putting aside the 2 vs. 4 byte identifier issue, let's discuss naming:
> I just realized that it talks about "replication identifier" as the new
> fundamental concept. The system table is called "pg_replication_identifier".
> But that's like talking about "index identifiers", instead of just indexes,
> and calling the system table pg_index_oid.
> The important concept this patch actually adds is the *origin* of each
> transaction. That term is already used in some parts of the patch. I think
> we should roughly do a search-replace of "replication identifier" ->
> "replication origin" to the patch. Or even "transaction origin".

Attached is a patch that does this, and some more, renaming. That was
more work than I'd imagined. I've also made the internal naming in
origin.c more consistent/simpler and did a bunch of other cleanup.

I'm pretty happy with this state.


Andres Freund

Attachment Content-Type Size
0001-Introduce-replication-progress-tracking-infrastructu.patch text/x-patch 135.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2015-04-24 12:32:34 Re: Parallel Seq Scan
Previous Message Robert Haas 2015-04-24 12:20:08 Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)