Re: recovery_target_action = pause & hot_standby = off

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>
Subject: Re: recovery_target_action = pause & hot_standby = off
Date: 2015-03-15 13:27:07
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2015-03-12 15:52:02 +0100, Andres Freund wrote:
> /*
> * Override any inconsistent requests. Not that this is a change
> * of behaviour in 9.5; prior to this we simply ignored a request
> * to pause if hot_standby = off, which was surprising behaviour.
> */
> if (recoveryTargetAction == RECOVERY_TARGET_ACTION_PAUSE &&
> recoveryTargetActionSet &&
> standbyState == STANDBY_DISABLED)

While it's easy enough to fix I rather dislike the whole intent here
though. *Silently* switching the mode of operation in a rather
significant way seems like a bad idea to me. At the very least we need
to emit a LOG message about this; but I think it'd be much better to
error out instead.

<9.5's behaviour was already quite surprising. But changing things to a
different surprising behaviour seems like a bad idea.


Andres Freund

Andres Freund
PostgreSQL Development, 24x7 Support, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2015-03-15 13:51:46 Re: recovery_target_action = pause & hot_standby = off
Previous Message Fabien COELHO 2015-03-15 10:22:01 Re: PATCH: pgbench - merging transaction logs