POLA violation with \c service=

From: David Fetter <david(at)fetter(dot)org>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: POLA violation with \c service=
Date: 2014-12-16 21:11:32
Message-ID: 20141216211132.GA382@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I've noticed that psql's \c function handles service= requests in a
way that I can only characterize as broken.

This came up in the context of connecting to a cloud hosting service
named after warriors or a river or something, whose default hostnames
are long, confusing, and easy to typo, so I suspect that service= may
come up more often going forward than it has until now.

For example, when I try to use

\c "service=foo"

It will correctly figure out which database I'm trying to connect to,
but fail to notice that it's on a different host, port, etc., and
hence fail to connect with a somewhat unhelpful error message.

I can think of a few approaches for fixing this:

0. Leave it broken.
1. Disable "service=" requests entirely in \c context, and error out if attempted.
2. Ensure that \c actually uses all of the available information.

Is there another one I missed?

If not, which of the approaches seems reasonable?

David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-12-16 21:17:22 Re: Logical Decoding follows timelines
Previous Message Peter Geoghegan 2014-12-16 21:11:08 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}