Re: Review of GetUserId() Usage

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review of GetUserId() Usage
Date: 2014-12-05 14:28:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > > 3. It messes around with pg_signal_backend(). There are currently no
> > > cases in which pg_signal_backend() throws an error, which is good,
> > > because it lets you write queries against pg_stat_activity() that
> > > don't fail halfway through, even if you are missing permissions on
> > > some things. This patch introduces such a case, which is bad.
> >
> > Good point, I'll move that check up into the other functions, which will
> > allow for a more descriptive error as well.
> Err, I'm missing something here, as pg_signal_backend() is a misc.c
> static internal function? How would you be calling it from a query
> against pg_stat_activity()?
> I'm fine making the change anyway, just curious..

Updated patch attached which move the ereport() out of
pg_signal_backend() and into its callers, as the other permissions
checks are done, and includes the documentation changes. The error
messages are minimally changed to match the new behvaior.



Attachment Content-Type Size
getuserid_cleanup_v2.patch text/x-diff 9.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-12-05 14:45:22 Re: Review of GetUserId() Usage
Previous Message Rahila Syed 2014-12-05 14:10:16 Re: [REVIEW] Re: Compression of full-page-writes