Re: [BUGS] BUG #10823: Better REINDEX syntax.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Marko Tiikkaja <marko(at)joh(dot)to>
Cc: Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, dmigowski(at)ikoffice(dot)de, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #10823: Better REINDEX syntax.
Date: 2014-09-02 20:33:01
Message-ID: 20140902203301.GC14037@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Marko Tiikkaja wrote:
> On 2014-09-02 22:24, Alvaro Herrera wrote:
> >Marko Tiikkaja wrote:
> >>Do we have some kind of an agreement on what this patch should look
> >>like? Is someone going to prepare an updated patch? Vik?
> >
> >I think the only issue left for this to be committable is reindexdb
> >--all previously mentioned.
>
> I scanned through the patch and found the exit_nicely() business a
> bit weird, so that might be another thing worth looking at.

Yeah, just rip that out and do PQfinish(conn); exit(1); as other exit
paths do, I'd think.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-09-02 20:41:29 Re: B-Tree support function number 3 (strxfrm() optimization)
Previous Message Marko Tiikkaja 2014-09-02 20:28:01 Re: [BUGS] BUG #10823: Better REINDEX syntax.

Browse pgsql-bugs by date

  From Date Subject
Next Message Joe Van Dyk 2014-09-03 03:58:47 Re: create database ... template = ... does not copy configuration parameters values
Previous Message Marko Tiikkaja 2014-09-02 20:28:01 Re: [BUGS] BUG #10823: Better REINDEX syntax.