Re: Enhancing pgbench parameter checking

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: coelho(at)cri(dot)ensmp(dot)fr
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Enhancing pgbench parameter checking
Date: 2014-08-07 09:41:14
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


> I have not tested, but the patch looks ok in principle.

Thanks for the review. I have registered it to Aug Commit fest.

> I'm not sure of the variable name "is_non_init_parameter_set". I would suggest "benchmarking_option_set"?

Ok, I will replace the variable name as you suggested.

> Also, to be consistent, maybe it should check that no initialization-specific option are set when benchmarking.

Good suggesition. Here is the v2 patch.

Best regards,
Tatsuo Ishii
SRA OSS, Inc. Japan

Attachment Content-Type Size
pgbench-v2.patch text/x-patch 4.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-08-07 10:03:40 Re: Proposal: Incremental Backup
Previous Message furuyao 2014-08-07 08:24:32 Re: pg_receivexlog add synchronous mode