[REVIEW] Re: Fix xpath() to return namespace definitions

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: [REVIEW] Re: Fix xpath() to return namespace definitions
Date: 2014-06-16 15:52:05
Message-ID: 20140616155205.GB14090@toroid.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2014-05-30 16:04:33 +0700, the(dot)apaan(at)gmail(dot)com wrote:
>
> While developing some XML processing queries, i stumbled on an old bug
> mentioned in http://wiki.postgresql.org/wiki/Todo#XML: Fix Nested or
> repeated xpath() that apparently mess up namespaces.

Thanks for the patch, and welcome to Postgres development.

I can confirm that it works fine. I have attached here a very slightly
tweaked version of the patch (removed trailing whitespace, and changed
some comment text).

I'm marking this ready for committer.

-- Abhijit

Attachment Content-Type Size
xpath-ns-fix-2.patch text/x-diff 4.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2014-06-16 16:27:41 Re: Why is it "JSQuery"?
Previous Message Stephen Frost 2014-06-16 15:28:35 Re: API change advice: Passing plan invalidation info from the rewriter into the planner?