Re: Retain dynamic shared memory segments for postmaster lifetime

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: amit(dot)kapila16(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Retain dynamic shared memory segments for postmaster lifetime
Date: 2014-02-13 00:22:56
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello, I've marked this patch as 'Ready for committer'.

> To be honest, I see no harm in changing the name as per your suggestion,
> as it can improve segment naming for dynamic shared memory segments,
> however there is no clear problem with current name as well, so I don't
> want to change in places this patch has no relation.

Okay, let's go with it as it is.

> I think best thing to do here is to put it as Notes To Committer, something
> like:
> Some suggestions for Committer to consider:
> "Change the name of dsm segments from .. to .."

> In general, what I see is that they consider all discussion in thread, but
> putting some special notes like above will reduce the chance of getting
> overlooked by them. I have done as a reviewer previously and it worked
> well.

Thank you for the sugestion.

> > However, it is a bit different thing from this patch so
> > I have no intention to compel to do the changing.
> Thanks to you for understanding my position.
> Thanks for reviewing the patch so carefully, especially Windows part
> which I think was bit tricky for you to setup.

It's my presure and I learned a lot.


Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-02-13 00:24:02 Re: narwhal and PGDLLIMPORT
Previous Message Craig Ringer 2014-02-12 23:58:09 Re: narwhal and PGDLLIMPORT