Re: [bug fix] pg_ctl fails with config-only directory

From: Christian Kruse <christian(at)2ndQuadrant(dot)com>
To: MauMau <maumau307(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl fails with config-only directory
Date: 2014-01-30 08:20:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


personally I really dislike constructs like you used:

#ifdef WIN32
if (check_if_admin)

It is hard to read and may confuse editors. Can you rewrite it?

The rest looks fine to me.

Best regards,

Christian Kruse
PostgreSQL Development, 24x7 Support, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Christian Kruse 2014-01-30 08:32:52 Re: Regression tests failing if not launched on db "regression"
Previous Message Craig Ringer 2014-01-30 08:05:25 Re: Row-security on updatable s.b. views