Re: [PATCH] configure: allow adding a custom string to PG_VERSION

From: Oskari Saarenmaa <os(at)ohmu(dot)fi>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] configure: allow adding a custom string to PG_VERSION
Date: 2013-11-19 23:08:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Nov 18, 2013 at 08:48:13PM -0500, Peter Eisentraut wrote:
> On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote:
> > This can be used to tag custom built packages with an extra version string
> > such as the git describe id or distribution package release version.
> I think this is a reasonable feature, and the implementation is OK, but
> I don't see why the format of the extra version information needs to be
> exactly
> I'd imagine, for example, that someone will want to do -something or
> +something. So I'd just make this
> Comments?

Sounds reasonable.

> > +# Allow adding a custom string to PG_VERSION
> > +PGAC_ARG_REQ(with, extra-version, [NAME], [extra version information],
> This could be indented better. It was a bit confusing at first.

Agreed. Attached an updated patch, or you can grab it from


Attachment Content-Type Size
0001-configure-allow-adding-a-custom-string-to-PG_VERSION.patch text/plain 1.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-11-19 23:41:58 Re: Data corruption issues using streaming replication on 9.0.14/9.2.5/9.3.1
Previous Message Alexander Korotkov 2013-11-19 23:06:34 Re: GIN improvements part2: fast scan