Re: port _srv.o makefile rules don't observe dependency tracking

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: port _srv.o makefile rules don't observe dependency tracking
Date: 2012-05-01 20:25:07
Message-ID: 20131.1335903907@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Peter Eisentraut's message of mar may 01 15:30:25 -0400 2012:
>> Instead, I thought this could easily be fixed by writing this:
>>
>> %_srv.o: %.c %.o
>> $(CC) $(CFLAGS) $(subst -DFRONTEND,, $(CPPFLAGS)) -c $< -o $@
>>
>> A bit hacky, but should get quite robust results.

> So basically to build the _srv.o file you first need to build the .o?
> Since both files need to be built anyway, I don't think this is a
> problem.

Are there, or might there be in the future, any "port" files that only
exist in server flavor and not client-side flavor? It doesn't seem
terribly unlikely to me. This is a cute hack but it assumes that
everything in that directory can and should be built both ways.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-05-01 20:34:03 Re: port _srv.o makefile rules don't observe dependency tracking
Previous Message Jim Nasby 2012-05-01 20:22:32 Re: Temporary tables under hot standby