Re: [PATCH] COPY .. COMPRESSED

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] COPY .. COMPRESSED
Date: 2013-01-15 19:53:29
Message-ID: 20130115195329.GU16126@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Bruce Momjian (bruce(at)momjian(dot)us) wrote:
> On Tue, Jan 15, 2013 at 10:55:04AM -0500, Stephen Frost wrote:
> > * Peter Eisentraut (peter_e(at)gmx(dot)net) wrote:
> > > Operating on compressed files transparently in file_fdw is obviously
> > > useful, but why only gzip?
> >
> > This isn't really an argument, imv. It's only gzip *right this moment*
> > because that's all that I implemented. I've already offered to add
> > bzip2 or whatever else people would like.
>
> And this leads to support-my-compression-binary-of-the-day mess. Why
> not just allow them to do '|compression-binary'?

You're right, to clarify, for *file_fdw*, which is a backend-only
operation, the popen patch is great (thought I made that clear before).

The popen patch doesn't support the '|compression-binary' option through
the FE protocol. Even if it did, it would only be available for
superusers as we can't allow regular users to run arbitrary commands on
the server-side.

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-01-15 19:55:34 Re: Get current query in a trigger function
Previous Message Josh Berkus 2013-01-15 19:51:54 Re: Save The Date: Cluster-Hackers meeting May 21st