| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Subject: | Re: WIP checksums patch |
| Date: | 2012-10-01 17:14:33 |
| Message-ID: | 20121001171433.GD30089@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 1, 2012 at 10:04:09AM -0700, Jeff Davis wrote:
> On Mon, 2012-10-01 at 12:35 -0400, Bruce Momjian wrote:
> > The heap/index files are copied unmodified from the old cluster, so
> > there are no checksums on the pages.
>
> That's fine though, the patch still reads the old format the same way,
> and the pages are treated as though they have no checksum. How is that a
> reason for defaulting the GUC to off?
No idea then.
> I'm missing something here. Are we worried about users who turn the GUC
> on and then expect all of their old data pages to magically be
> protected?
Perhaps we don't allow this to be turned per page, but rather per
cluster, and per-cluster would require the entire cluster to be
rewritten.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2012-10-01 17:22:19 | Re: WIP checksums patch |
| Previous Message | Simon Riggs | 2012-10-01 17:14:18 | Re: WIP checksums patch |