Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Date: 2012-08-16 22:52:34
Message-ID: 20120816225234.GC30286@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Aug 16, 2012 at 11:15:24AM -0400, Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of mié ago 15 18:30:40 -0400 2012:
> >
> > On Wed, Sep 7, 2011 at 01:20:17AM +0300, Ants Aasma wrote:
> > > On Tue, Sep 6, 2011 at 10:18 PM, Alvaro Herrera
> > > <alvherre(at)commandprompt(dot)com> wrote:
> > > > I wonder what happens if files in the same subdir are grouped in a
> > > > subgraph.  Is that possible?
> > >
> > > Possible, and done. Also added possivility to add .c files to the graph,
> > > coloring by subdir and possibility exclude nodes from the graph. I didn't yet
> > > bother to clean up the code - to avoid eye damage, don't look at the source.
> > >
> > > Bad news is that it doesn't significantly help readability for the all nodes
> > > case. See all_with_subgraphs.svgz. It does help for other cases.
> > > For example parsenodes.h.svgz has the result for
> > > render_includes.py --select='nodes/parsenodes.h+*-*' --subgraphs
> > > and execnodes.h.svgz for
> > > --subgraphs --select='nodes/execnodes.h+*-*'
> >
> > Should we add this script and instructions to src/tools/pginclude?
>
> Probably not, but maybe the developer FAQ in the wiki?

I just added the script email URL to the pginclude README.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2012-08-16 23:03:09 pgsql: Delete inaccurate C comment about FSM and adding pages, per Robe
Previous Message Bruce Momjian 2012-08-16 22:52:22 pgsql: Add URL for include file visualization tool.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-08-16 23:03:08 Re: heap_page_prune comments
Previous Message Bruce Momjian 2012-08-16 22:44:45 Re: Unreproducible bug in snapshot import code