Re: ecpglib use PQconnectdbParams

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Christian Ullrich <chris(at)chrullrich(dot)net>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpglib use PQconnectdbParams
Date: 2012-02-06 16:50:44
Message-ID: 20120206165044.GA16393@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote:
> * Peter Eisentraut wrote:
> >I noticed ecpglib still uses PQconnectdb() with a craftily assembled
> >connection string. Here is a patch to use PQconnectdbParams() instead.
>
> + const char *conn_keywords[6];
> + const char *conn_values[6];
>
> Shouldn't these be [7]? You can have up to 6 items, plus the terminator.

This bug is now in GIT.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-02-06 16:57:30 Re: about type cast
Previous Message Robert Haas 2012-02-06 16:19:14 Re: freezing multixacts