Re: [v9.2] make_greater_string() does not return a string in some cases

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp>
To: robertmhaas(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases
Date: 2011-10-13 03:45:31
Message-ID: 20111013.124530.97708970.horiguchi.kyotaro@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hello, the work is finished.

Version 4 of the patch is attached to this message.

- Add rough description of the algorithm as comment to
pg_utf8_increment() and pg_eucjp_increment().

- Fixed a bug of pg_utf8_increment() found while
working. pg_(utf8|eucjp)_increment are retested on whole valid
code points to be properly handled.

- The comment previously pointed out as being wrong in grammar
is left untouched. I'm sorry to bother you with my poor
English.

At Tue, 11 Oct 2011 16:55:00 +0900 (JST), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp> wrote
> > One thing I still think it would be useful to add,
> > though, is some comments to pg_utf8_increment() and
> > pg_eucjp_increment() describing the algorithm being used. Can you
> > take a crack at that?
>
> Yes I'll do it in a day or two.

Regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
charinc_20111013_v4.patch text/x-patch 11.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2011-10-13 04:09:36 Re: pl/perl example in the doc no longer works in 9.1
Previous Message Josh Berkus 2011-10-13 03:43:15 Re: unite recovery.conf and postgresql.conf

Browse pgsql-bugs by date

  From Date Subject
Next Message Vishnu S. 2011-10-13 12:53:17 Tablespace files deleted in continuous run
Previous Message Craig Ringer 2011-10-13 02:55:07 Re: BUG #6252: After drop the default database 'postgres', I can not create a database by 'createdb.exe'