| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeremy Drake <pgsql(at)jdrake(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Date: | 2011-09-04 01:25:17 |
| Message-ID: | 201109040125.p841PH427429@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Alvaro Herrera wrote:
> >> Hmm, so you included walsender.h into xlog.h? That seems a bit funny
> >> considering that walsender.h already includes xlog.h. It seems the
> >> reason for this is only the AllowCascadeReplication() definition. Maybe
> >> that should go elsewhere instead, for example walsender.h?
>
> > Moved to walsender.h. Thanks.
>
> You seem to have entirely missed the point of Alvaro's remark, which is
> that you've got xlog.h including walsender.h (still) as well as
> walsender.h including xlog.h. That's broken.
Oh, OK, done. xlog.h removed from walsender.h and tested.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-09-04 01:25:40 | pgsql: walsender.h doesn't need xlog.h, per Tom. |
| Previous Message | Tom Lane | 2011-09-04 01:08:41 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-04 01:48:38 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Previous Message | Tom Lane | 2011-09-04 01:08:41 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |