Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID
Date: 2011-07-12 01:34:18
Message-ID: 201107120134.p6C1YIu06164@momjian.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

Simon Riggs wrote:
> On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote:
> >> Robert Hass (whose name I misspelled in the commit message above) just
> >> mentioned to me (in an answer to my apologizing about it) that he
> >> didn't think that mentioning sponsors for patch development was a good
> >> idea.
> >>
> >> I don't think we have a policy for this, but I have done it for some
> >> time now and nobody has complained, so I sort of assumed it was okay.
> >> Besides, some of the people pouring the money in does care about it;
> >> moreover, it provides a little incentive for other companies that
> >> might also be in a position to fund development but lack the "peer
> >> approval" of the idea, or a final little push.
> >
> > I think commit messages should be restricted to describing what was
> > changed and who is responsible for it. ?Once we open it for things like
> > sponsorship, what's to stop people from adding personal messages, what
> > they had for breakfast, "currently listening to", or just selling
> > advertising space in each commit message for 99 cents?
>
> Agreed.
>
> We should credit people somewhere, but not here.
>
> Otherwise, we'll be forced to add "Sponsored by RedHat", "Sponsored by
> 2ndQuadrant" etc onto commit messages.

Agreed. On one level I like the sponsor message, but on the other
having "Sponsored by RedHat" on every Tom Lane item will get tiring.
;-)

Can we add text if the employer is _not_ the feature sponsor?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-07-12 01:55:29 Re: relpersistence and temp table
Previous Message Chris Travers 2011-07-12 01:25:58 Re: [HACKERS] Creating temp tables inside read only transactions

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-07-12 04:15:55 pgsql: Make pg_upgrade output more consistent with project style
Previous Message Bruce Momjian 2011-07-12 00:33:09 pgsql: Add C comment that txid_current() assigns an XID if one is nota