pgAdmin III commit: Fix lots of bugs in foreign table support

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix lots of bugs in foreign table support
Date: 2011-04-29 23:42:42
Message-ID: 201104292342.p3TNggOC049668@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix lots of bugs in foreign table support

The load of existing foreign tables didn't work well. The contents of
ftoptions in pg_foreign_table strangely isn't compatible with the CREATE
FOREIGN TABLE syntax, so I had to add a function to parse the contents of this
field.

Contents of the types widgets weren't set to blank once a type was added.

And the use of the edit grid window started with a big crash: segmentation
fault.

Per a report from Thom Brown.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=dee63a2176031dd451c7f58f70d36ae052c9ea6b

Modified Files
--------------
pgadmin/dlg/dlgForeignTable.cpp | 46 +++++++--------
pgadmin/frm/frmEditGrid.cpp | 8 +++
pgadmin/include/schema/pgForeignTable.h | 10 ++-
pgadmin/include/utils/misc.h | 1 +
pgadmin/schema/pgForeignTable.cpp | 92 +++++++++++++++++++++++++++++-
5 files changed, 125 insertions(+), 32 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-04-30 07:02:44 pgAdmin website commit: 1.12.2 is available since 2011-04-18.
Previous Message Guillaume Lelarge 2011-04-29 23:41:11 Re: Bug with Foreign table interface