pgAdmin III commit: Revert the previous change that introduced sysSetti

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date: 2011-02-17 11:31:30
Message-ID: 201102171131.p1HBVUxx053617@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Revert the previous change that introduced sysSettings::WriteBool(),
and restore the previous Write() overload. Whilst the change was, in
theory, good, it failed to take into account that users of previous
versions of pgAdmin would have true/false values stored in the
Windows registry as REG_SZ values of "true" or "false", not REG_DWORDs
as the new code would write. Needs more thought, and thorough testing
on Windows when we re-visit this.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=aedd49e2b7bfd3104b5a9f30a4e70c0ea2892170

Modified Files
--------------
pgadmin/include/utils/sysSettings.h | 6 +++++-
pgadmin/utils/sysSettings.cpp | 11 ++++++-----
2 files changed, 11 insertions(+), 6 deletions(-)

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-02-17 11:33:27 Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Previous Message Dave Page 2011-02-17 09:17:44 Re: phase 2 of wxWidgets 2.9 build