pgsql: Bring some sanity to the trace_recovery_messages code and docs.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Bring some sanity to the trace_recovery_messages code and docs.
Date: 2010-08-19 22:55:01
Message-ID: 20100819225501.5E1AE7541D7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Bring some sanity to the trace_recovery_messages code and docs.
Per gripe from Fujii Masao, though this is not exactly his proposed patch.
Categorize as DEVELOPER_OPTIONS and set context PGC_SIGHUP, as per Fujii,
but set the default to LOG because higher values aren't really sensible
(see the code for trace_recovery()). Fix the documentation to agree with
the code and to try to explain what the variable actually does. Get rid
of no-op calls trace_recovery(LOG), which accomplish nothing except to
demonstrate that this option confuses even its author.

Modified Files:
--------------
pgsql/doc/src/sgml:
config.sgml (r1.304 -> r1.305)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.304&r2=1.305)
pgsql/src/backend/storage/ipc:
standby.c (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/ipc/standby.c?r1=1.28&r2=1.29)
pgsql/src/backend/utils/error:
elog.c (r1.225 -> r1.226)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/error/elog.c?r1=1.225&r2=1.226)
pgsql/src/backend/utils/misc:
guc.c (r1.567 -> r1.568)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.567&r2=1.568)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-08-19 22:55:10 pgsql: Bring some sanity to the trace_recovery_messages code and docs.
Previous Message Tom Lane 2010-08-19 18:58:11 pgsql: Allow USING and INTO clauses of plpgsql's EXECUTE to appear in