| From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: xmlconcat (was 9.0 release notes done) |
| Date: | 2010-04-02 06:39:42 |
| Message-ID: | 20100402153942.976B.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Hmm. OK. Well here is a patch that tries to fix the xmlconcat error,
> anyway. It seems to work, but maybe could stand a little tightening.
Can we take the patch for 9.0? The bug is registered as an open item:
http://wiki.postgresql.org/wiki/PostgreSQL_9.0_Open_Items
As far as the patch, I found there are still two issues even after it applied:
1. A linebreak is added at the line end DOCTYPE exists.
=# SELECT xmlconcat('foo', xmlparse(DOCUMENT '<!DOCTYPE html><html/>'));
xmlconcat
------------
foo<html/>+
(1 row)
2. DOCUMENT could have <?xml> before DOCTYPE.
=# SELECT xmlconcat('foo', xmlparse(DOCUMENT '<?xml version="1.0"?> <!DOCTYPE html> <html/>'));
xmlconcat
-----------
foo
(1 row)
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takahiro Itagaki | 2010-04-02 07:25:14 | Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c |
| Previous Message | Josh Berkus | 2010-04-02 06:28:44 | Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c |