Re: BUG #5394: invalid declspec for PG_MODULE_MAGIC

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: "Vladimir Barzionov" <snego(dot)barsik(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: BUG #5394: invalid declspec for PG_MODULE_MAGIC
Date: 2010-03-29 09:47:05
Message-ID: 20100329184705.A60E.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers


"Vladimir Barzionov" <snego(dot)barsik(at)gmail(dot)com> wrote:

> Same problem was already discussed for example here
> http://dbaspot.com/forums/postgresql/393683-re-general-custom-c-function-palloc-broken.html
>
> Looks like the simplest way for correcting the issue is declaring additional
> macro (something like PGMODULEEXPORT)

Sure, I agree it is a longstanding bug in PostgreSQL. Developers who use
MSVC (not mingw) always encounter the bug; machines in the buildfarm can
build Windows binaries just because they have non-standard equipments.

A patch attached. The name of "PGMODULEEXPORT" might be arguable.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Attachment Content-Type Size
PGMODULEEXPORT.patch application/octet-stream 2.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gokulakannan Somasundaram 2010-03-29 10:42:08 Re: GSoC Query
Previous Message Peter Eisentraut 2010-03-29 09:22:48 Re: Patch for 9.1: initdb -C option

Browse pgsql-bugs by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2010-03-29 11:16:11 Re: Known Issues Page
Previous Message Tharakan, George (GE Healthcare) 2010-03-29 08:56:32 Known Issues Page