pgsql: Instead of trying (and failing) to allow <<label>> at the end of

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Instead of trying (and failing) to allow <<label>> at the end of
Date: 2010-03-03 01:53:17
Message-ID: 20100303015317.E1EFA7541D0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Instead of trying (and failing) to allow <<label>> at the end of a DECLARE
section, throw an error message saying explicitly that the label must go
before DECLARE. Per investigation of a recent pgsql-novice question,
this code did not work as intended in any modern PG version, maybe not ever.
Allowing such a thing would only create ambiguity anyway, so it seems better
to remove it than fix it.

Modified Files:
--------------
pgsql/src/pl/plpgsql/src:
gram.y (r1.141 -> r1.142)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/gram.y?r1=1.141&r2=1.142)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2010-03-03 03:14:09 pgsql: Restructure CREATE FUNCTION "NOTES" section to be shorter; move
Previous Message User Itagaki 2010-03-03 01:41:12 textsearch-ja - textsearch_senna: win32 ports.

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-03-03 01:56:45 Re: Hot Standby query cancellation and Streaming Replication integration
Previous Message Tom Lane 2010-03-03 01:46:49 Re: Placement of block label in plpgsql block with DECLARE