Skip site navigation (1) Skip section navigation (2)

plperl message style on newly added messages

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: plperl message style on newly added messages
Date: 2010-02-15 15:02:50
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers

I notice that the new plperl error messages are somewhat out of line of
our usual style:

                        errmsg("while executing utf8fix"),
                        errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));

I think the errdetail field should really be errmsg, and the errdetail
should be errcontext.

There are several messages like this.

Should this be fixed?

Alvaro Herrera                      
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date

Next:From: Robert HaasDate: 2010-02-15 15:08:10
Subject: Re: TCP keepalive support for libpq
Previous:From: Greg StarkDate: 2010-02-15 14:55:43
Subject: Re: Explain buffers display units.

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group