| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Provide rowcount for utility SELECTs |
| Date: | 2010-02-11 19:38:53 |
| Message-ID: | 20100211193853.GG3145@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas escribió:
> I was all prepared to admit that I hadn't actually looked at the patch
> carefully enough, but I just looked at (and CVS HEAD) again and what
> you've written here doesn't appear to describe what I'm seeing in the
> code:
>
> if ((portal->strategy != PORTAL_ONE_SELECT) && (!portal->holdStore))
> FillPortalStore(portal, isTopLevel);
>
> So one of us is confused... it may well be me.
Ah, it seems I misread it ... but then I don't quite see the point in
that change.
Well, not doing a full review anyway, so never mind me.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-02-11 19:39:24 | Re: log_error_verbosity function display |
| Previous Message | Robert Haas | 2010-02-11 19:36:37 | Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while |