Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH]

Robert Haas escribió:
> On Tue, Feb 2, 2010 at 10:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
> >> On Sat, Jan 30, 2010 at 08:49, Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com> wrote:
> >>> This is an update the fourth of the patches to be split out from the
> >>> former 'plperl feature patch 1'.
> >>>
> >>> Changes in this patch:
> >>>
> >>> - Adds plperl.on_trusted_init and plperl.on_untrusted_init GUCs
> >>>    on_trusted_init is PGC_USERSET, on_untrusted_init is PGC_SUSET
> >>
> >> Im not a fan of the names (I think everyone gets trusted vs untrusted
> >> confused). May I humbly suggest:
> >> plperl.on_init
> >> plperlu.on_init
> >> plperl.both_on_init <- this one is the one that throws the scheme off :(

> > With all due respect.... yuck.
>
> OK, third time is the charm. Sigh. The "yuck" was in reference
> specifically to the proposed GUC names.
>
> I like the original ones better.

With all due respect, I think you should get more used to trimming the
message you're replying to, so that your reply makes more sense to the
readership at large. I fully realize that Gmail is not the best
platform for that :-(

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support