| From: | Roger Leigh <rleigh(at)codelibre(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Unicode UTF-8 table formatting for psql text output |
| Date: | 2009-11-15 23:47:18 |
| Message-ID: | 20091115234717.GA3099@codelibre.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 15, 2009 at 12:50:14AM +0000, Roger Leigh wrote:
> On Sat, Nov 14, 2009 at 01:31:29PM -0500, Tom Lane wrote:
> > Roger Leigh <rleigh(at)codelibre(dot)net> writes:
> > > The side effect from this change is that some of the testsuite
> > > expected data will need updating due to the extra pad spaces
> >
> > No, we are *not* doing that. Somebody made a change to the print.c
> > logic last year that started adding "harmless" white space to the
> > last column, and it was a complete disaster for tracking whether
> > anything important had changed in regression test output. Please
> > undo that part of your patch.
>
> No problem, done as requested. I've attached an updated patch that
> takes care to exactly match the trailing whitespace the existing
> psql outputs. This fixes most of the changes between observed and
> expected test results.
Attached is an updated patch with a couple of tweaks to ensure output
is formatted and spaced correctly when border=0, which was off in the
last patch.
Regards,
Roger
--
.''`. Roger Leigh
: :' : Debian GNU/Linux http://people.debian.org/~rleigh/
`. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/
`- GPG Public Key: 0x25BFB848 Please GPG sign your mail.
| Attachment | Content-Type | Size |
|---|---|---|
| psql-wrap-formatting3.patch | text/x-diff | 30.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-11-16 00:17:51 | Re: Aggregate ORDER BY patch |
| Previous Message | Emmanuel Cecchet | 2009-11-15 23:41:15 | Re: Partitioning option for COPY |